Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #5

Merged
merged 33 commits into from
Mar 22, 2024
Merged

Dev #5

merged 33 commits into from
Mar 22, 2024

Conversation

SandroMartens
Copy link
Owner

Renamed functions and variables.
restructuring
added exponential weight for distance calcuation
performance improvements
winning neurpons are caöculated using sklearn nearest neighbors function

@SandroMartens
implemented faster method for quantization error
738237c
@SandroMartens
updated _distribute_errors() for better readability
de4f431
@SandroMartens
update _add_new_neurons()
f556a33
@SandroMartens
_calculate_topographic_error() now uses vectorized np functions
5f598e7
@SandroMartens
small updates for better performance
152eba7
@SandroMartens
simplified function
e3cc3d8
@SandroMartens
we now use ball trees for search of winning neurons
e50271c
@SandroMartens
Improve _write_accumulative_error()
4bffa7b
@SandroMartens
_get_winning_neurons() now also returns a distance vector
dbecff6
@SandroMartens
updated all calls to _get_winning_neurons()
93fba54
@SandroMartens
we now reuse the computation of the quantization errors of the samples
294e8e7
@SandroMartens
more unnecessary code and comments removed
3ecd1fc
@SandroMartens
added type hints, small performance improvements
638b4dd
@SandroMartens
updated formatting in example notebooks
e2574e5
@SandroMartens
small updates for readability
1b5e5a7
@SandroMartens
fixed _get_winning_neurons()
b3c336c
@SandroMartens
small update for readability
69a75d5
@SandroMartens
small fixes
791e511
@SandroMartens
updated some examples
a7b9dee
@SandroMartens
updated somvq to better follow the sklearn api
d13633c
@SandroMartens
fix topographic error
20feb6e
@SandroMartens
implemented topographic error function
5740d49
@SandroMartens
made topographic error more readable
08bbbda
@SandroMartens
fix new topographic error function
81f80ad
@SandroMartens
added type hints
7a0d5d8
@SandroMartens
fixed get_winning_neurons, small changes
acd50c6
@SandroMartens
renamed topographic_function(), return array normalized to largest di…
f2bb5f4 
…stance
@SandroMartens
topographic_function now uses numpy more efficiently
b38654d
@SandroMartens
small changes and cleanup
d5ef216
@SandroMartens
implemented smoothing factor
aeb3fd6
@pep8speaks
Copy link

Hello @SandroMartens! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 27:80: E501 line too long (81 > 79 characters)
Line 159:80: E501 line too long (83 > 79 characters)
Line 382:80: E501 line too long (80 > 79 characters)
Line 471:80: E501 line too long (80 > 79 characters)
Line 534:80: E501 line too long (82 > 79 characters)
Line 565:80: E501 line too long (81 > 79 characters)
Line 566:80: E501 line too long (80 > 79 characters)
Line 567:80: E501 line too long (80 > 79 characters)
Line 955:80: E501 line too long (86 > 79 characters)
Line 960:80: E501 line too long (84 > 79 characters)
Line 1066:80: E501 line too long (87 > 79 characters)

Line 131:80: E501 line too long (83 > 79 characters)

@SandroMartens SandroMartens merged commit acfc6d7 into main Mar 22, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SandroMartens @pep8speaks